Improve goal execution timing precision by excluding scheduling overhead #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses timing measurement accuracy in goal execution by separating scheduling overhead from actual function execution time. Previously, the timing measurement included overhead from function imports, transaction setup, and context preparation, making it difficult to get accurate performance metrics for goal handlers.
Problem
The existing timing measurement in
_pursue_goal_core()
captured the total time from the start of goal processing to completion, which included:import_string()
overhead for loading the handler functionThis made it impossible to distinguish between scheduling/setup time and actual execution time, especially for goals that were initially blocked and later unblocked.
Solution
This PR moves timing measurement deeper into the execution flow to capture only the actual function execution time:
Precise timing in
follow_instructions()
: Timing now starts just before the actual handler function call and ends immediately after, excluding all setup overhead.Thread-local timing storage: Added
execution_time
field toGoalsThreadLocal
to pass precise timing fromfollow_instructions()
to_pursue_goal_core()
.Robust exception handling: Ensures timing is captured correctly even when exceptions occur during execution.
Example
Benefits
blocked
parameter behavior is preservedThe changes are minimal (27 lines added, 3 modified) and maintain full backward compatibility while providing significantly more accurate timing data for goal execution monitoring and optimization.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com
/usr/lib/apt/methods/https
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.