Added checks for loggers and repr + updated setup.py test commands #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkralidis
requested changes
Aug 5, 2022
PhilippeTh
force-pushed
the
unittest_add_tests_logger
branch
from
d0648e3 to
8f93800
Compare
|
@tomkralidis Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added last little checks. Checked the
__repr__functions, added checks for warning and error loggers to see that they were called. Not the message it is sending, simply whether theLOGGER.warningorLOGGER.erroris called, as I believed the message itself might be subject to change (although quite easy to add if we ever feel the need to).LOGGER.debugweren't asserted as they seemed less important. Finally, setup.py was changed so thepython setupy.py testandpython setupy.py coveragecommands work.