feat: 사용자 닉네임 제한 기능 추가 #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- UserProperties 클래스를 생성하여 금지된 닉네임 목록을 관리. - UserService에서 닉네임 중복 및 금지된 닉네임 검증 로직 추가. - application.yml 파일에 금지된 닉네임 설정 추가.
JjungminLee
approved these changes
Jun 25, 2025
| } | ||
|
|
||
| private boolean isForbiddenNickname(String nickname) { | ||
| return userProperties.getForbiddenNicknames().stream() |
Collaborator
There was a problem hiding this comment.
[문의] 이미 UserProperties에서
private List<String> forbiddenNicknames = new ArrayList<>();이런식으로 초기화해두셔서 NPE 날 확률이 없을것 같긴한데 좀 더 NPE를 방어하는 로직이 있었으면 어떨까 하네요. 최근 스웨거로 테스트하면서 NPE때문에 500나는 경우가 왕왕 있더라구요.
Contributor
Author
There was a problem hiding this comment.
오! NPE가 무엇인지 잘 모르겠지만, 한 번 확인해서 조치를 해보겠습니다. 일단 승인을 해주셨어서, 병합을 하고 후속조치로 바로 한 번 연구를 해볼게요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ Issue Number
📝 요약(Summary)
application.yml에 작성되어있는 금지된 닉네임 항목을 가져와서 클라이언트가 닉네임으로 사용할 수 없도록 코드를 작성했습니다.💬 공유사항 to 리뷰어
✅ PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.