-
Notifications
You must be signed in to change notification settings - Fork 0
[Feat] 로그인 v2 api 작업 #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[Feat] 로그인 v2 api 작업 #437
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ee5a324
refactor: DeviceType을 추가한 login v2 api로 교체 및 각 레이어 위반사항을 리팩토링
HI-JIN2 9eed94b
Update app/src/main/java/com/eatssu/android/data/remote/dto/request/L…
HI-JIN2 2534363
Update app/src/main/java/com/eatssu/android/domain/usecase/auth/Login…
HI-JIN2 36981b9
Update core/common/src/main/java/com/eatssu/common/enums/DeviceType.kt
HI-JIN2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 6 additions & 2 deletions
8
app/src/main/java/com/eatssu/android/domain/repository/OauthRepository.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 7 additions & 3 deletions
10
app/src/main/java/com/eatssu/android/domain/usecase/auth/LoginUseCase.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,17 @@ | ||
| package com.eatssu.android.domain.usecase.auth | ||
|
|
||
| import com.eatssu.android.data.remote.dto.request.LoginWithKakaoRequest | ||
| import com.eatssu.android.domain.model.Token | ||
| import com.eatssu.android.domain.repository.OauthRepository | ||
| import com.eatssu.common.enums.DeviceType | ||
| import javax.inject.Inject | ||
|
|
||
| class LoginUseCase @Inject constructor( | ||
| private val oauthRepository: OauthRepository, | ||
| ) { | ||
| suspend operator fun invoke(body: LoginWithKakaoRequest): Token? = | ||
| oauthRepository.login(body) | ||
| suspend operator fun invoke( | ||
| email: String, | ||
| providerId: String, | ||
| deviceType: DeviceType, | ||
| ): Token? = | ||
| oauthRepository.login(email, providerId, deviceType) | ||
| } | ||
HI-JIN2 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
core/common/src/main/java/com/eatssu/common/enums/DeviceType.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| package com.eatssu.common.enums | ||
|
|
||
| enum class DeviceType { | ||
| IOS, ANDROID | ||
| } | ||
HI-JIN2 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.