Skip to content

[Fix] material 의존성 제거 #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HI-JIN2 merged 1 commit into from
Nov 25, 2025
Merged

[Fix] material 의존성 제거 #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ dependencies {

implementation(libs.androidx.core.ktx)
implementation(libs.androidx.appcompat)
implementation(libs.material)
implementation(libs.androidx.constraintlayout)
implementation(libs.threetenabp)
implementation(libs.material.calendarview)
Expand Down
1 change: 0 additions & 1 deletion core/common/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ dependencies {

implementation(libs.androidx.core.ktx)
implementation(libs.androidx.appcompat)
implementation(libs.material)
testImplementation(libs.junit)
androidTestImplementation(libs.androidx.test.ext.junit)
androidTestImplementation(libs.androidx.espresso.core)
Expand Down
1 change: 0 additions & 1 deletion core/design-system/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ dependencies {

implementation(libs.androidx.core.ktx)
implementation(libs.androidx.appcompat)
implementation(libs.material)
testImplementation(libs.junit)
androidTestImplementation(libs.androidx.test.ext.junit)
androidTestImplementation(libs.androidx.espresso.core)
Expand Down
4 changes: 1 addition & 3 deletions core/design-system/src/main/java/com/eatssu/design_system/component/EatSsuTopBar.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ package com.eatssu.design_system.component

import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.filled.Close
import androidx.compose.material3.CenterAlignedTopAppBar
import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.Icon
Expand Down Expand Up @@ -69,7 +67,7 @@ fun CloseTopBar(
actions = {
IconButton(onClick = onClose) {
Icon(
imageVector = Icons.Filled.Close,
painter = painterResource(id = R.drawable.ic_close),
contentDescription = "닫기",
tint = Gray500
)
Expand Down
13 changes: 13 additions & 0 deletions core/design-system/src/main/res/drawable/ic_close.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<vector xmlns:android="http://schemas.android.com/apk/res/android"
android:width="24dp"
android:height="24dp"
android:viewportWidth="24"
android:viewportHeight="24">
<path
android:fillColor="#00000000"
android:pathData="M18,6L6,18M6,6L18,18"
android:strokeWidth="2"
android:strokeColor="#9D9D9D"
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

새로 추가된 아이콘의 strokeColor에 특정 색상(#9D9D9D)이 하드코딩되어 있습니다. 이 아이콘은 Icon 컴포저블의 tint 파라미터를 통해 색상이 지정되므로, 벡터 드로어블 자체에는 특정 테마 색상을 하드코딩하지 않는 것이 좋습니다. 이렇게 하면 아이콘의 재사용성이 높아지고, 테마 색상이 변경될 때 발생할 수 있는 불일치를 방지할 수 있습니다. 일반적으로 틴팅을 적용할 아이콘은 검은색 (#FF000000)으로 정의하는 것이 표준적인 방법입니다. 이 방식을 다른 아이콘(ic_arrow_left.xml 등)에도 일관되게 적용하는 것을 고려해 보세요.

Suggested change
android:strokeColor="#9D9D9D"
android:strokeColor="#FF000000"

android:strokeLineCap="round"
android:strokeLineJoin="round" />
</vector>
2 changes: 0 additions & 2 deletions gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ composeThemeAdapter = "1.2.1"
lifecycleRuntimeKtx = "2.5.2"
lifecycleViewmodelCompose = "2.8.7"
mapSdk = "3.21.0"
material = "1.8.0"
constraintlayout = "2.1.4"
naverMapCompose = "1.8.2"
naverMapLocation = "21.0.2"
Expand Down Expand Up @@ -143,7 +142,6 @@ play-services-base = { group = "com.google.android.gms", name = "play-services-b
# etc
accompanist-appcompat-theme = { group = "com.google.accompanist", name = "accompanist-appcompat-theme", version.ref = "accompanistAppcompatTheme" }
compose-theme-adapter = { group = "com.google.android.material", name = "compose-theme-adapter", version.ref = "composeThemeAdapter" }
material = { group = "com.google.android.material", name = "material", version.ref = "material" }
threetenabp = { group = "com.jakewharton.threetenabp", name = "threetenabp", version.ref = "threetenabp" }
material-calendarview = { group = "com.prolificinteractive", name = "material-calendarview", version.ref = "material-calendarview" }
transport-runtime = { group = "com.google.android.datatransport", name = "transport-runtime", version.ref = "transport-runtime" }
Expand Down