Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,6 @@
android:name="android.app.lib_name"
android:value="" />
</activity>
<activity
android:name=".presentation.error.ServerErrorActivity"
android:exported="false" />
<activity
android:name="com.kakao.sdk.auth.AuthCodeHandlerActivity"
android:exported="true">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ abstract class BaseActivity<B : ViewBinding>(

// refreshtoken 관리
observeTokenExpiration()
observeNetworkError()

setContainerInset()

Expand Down Expand Up @@ -120,8 +121,6 @@ abstract class BaseActivity<B : ViewBinding>(
navigateToLogin()
}
}

observeNetworkError()
}

private fun navigateToLogin() {
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ class IntroActivity : AppCompatActivity() {

observeState()
observeEvents()
observeNetworkError()

lifecycleScope.launch {
// 버전 체크 결과 관찰
Expand Down Expand Up @@ -88,8 +89,6 @@ class IntroActivity : AppCompatActivity() {
}
}
}

observeNetworkError()
}

private fun log() {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,39 +1,51 @@
package com.eatssu.android.presentation.util

import android.app.Activity
import android.app.AlertDialog
import android.content.Intent
import androidx.appcompat.app.AppCompatActivity
import androidx.lifecycle.lifecycleScope
import com.eatssu.android.R
import com.eatssu.android.presentation.base.NetworkErrorEventBus
import com.eatssu.android.presentation.error.ServerErrorActivity
import kotlinx.coroutines.launch

inline fun <reified T : Activity> AppCompatActivity.startActivity(block: Intent.() -> Unit = {}) {
startActivity(Intent(this, T::class.java).apply(block))
}

/**
* NetworkErrorEventBus를 구독하여 네트워크 에러 발생 시 ServerErrorActivity로 이동합니다.
* NetworkErrorEventBus를 구독하여 네트워크 에러 발생 시 다이얼로그를 표시합니다.
* 액티비티를 종료하지 않아 진행 중인 요청이 취소되지 않습니다.
*/
fun AppCompatActivity.observeNetworkError(
errorTitle: String? = null,
errorMessage: String? = null
) {
var networkErrorDialog: AlertDialog? = null

lifecycleScope.launch {
NetworkErrorEventBus.networkError.collect {
val intent = Intent(this@observeNetworkError, ServerErrorActivity::class.java).apply {
putExtra(
ServerErrorActivity.EXTRA_TITLE,
errorTitle ?: getString(R.string.server_error_title)
)
putExtra(
ServerErrorActivity.EXTRA_MESSAGE,
errorMessage ?: getString(R.string.server_error_message)
)
if (networkErrorDialog?.isShowing == true) {
return@collect
}
startActivity(intent)
finish()

val title = errorTitle ?: getString(R.string.server_error_title)
val message = errorMessage ?: getString(R.string.server_error_message)

networkErrorDialog = AlertDialog.Builder(this@observeNetworkError)
.setTitle(title)
.setMessage(message)
.setPositiveButton(getString(R.string.confirm)) { dialog, _ ->
dialog.dismiss()
}
.setCancelable(true)
.create()
.also { dialog ->
dialog.setOnDismissListener {
networkErrorDialog = null
}
dialog.show()
}
Comment on lines +32 to +48
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이부분이 슬랙에서 의견주신 다이얼로그 -> 토스트, 사용 문구 변경 맞죵? 요 부분만 반영되면 될 것 같네요!

그리고 추가적으로 해당 PR은 모두 문제 없는 것 같은데
브랜치 이동해서 observeNetworkError 확장함수 호출부를 봤는데요

사진처럼 각각 observeEvent(), observeTokenExpiration()함수 내부에 있는게 제가 보기엔 조금 부자연스러워보여서요!
혹시 해당 함수 호출부 액티비티 두곳 모두에서 onCreate()함수 내부에서 바로 호출해서 뎁스를 줄이는 거는 어떻게 생각하시나용?

Image Image

}
}
}