-
Notifications
You must be signed in to change notification settings - Fork 0
release 3.1.7 #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release 3.1.7 #415
Conversation
Summary of ChangesHello @HI-JIN2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 애플리케이션의 새로운 버전인 3.1.7을 릴리즈하기 위한 것입니다. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
3.1.7 릴리즈를 위한 버전 업데이트군요. versionCode와 versionName이 올바르게 수정되었습니다. app/build.gradle.kts 파일을 검토하던 중 release와 debug 빌드 타입에 중복된 코드가 있는 것을 발견했습니다. 이번 변경 사항의 범위는 아니지만, local.properties에서 값을 읽어와 buildConfigField와 manifestPlaceholders를 설정하는 로직을 공통 함수로 추출하면 향후 유지보수성이 향상될 것입니다.
| versionCode = 45 | ||
| versionName = "3.1.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
버전 정보를 build.gradle.kts 파일에 직접 하드코딩하기보다 version.properties와 같은 별도 파일로 분리하여 관리하는 것을 권장합니다. 이 방식은 다음과 같은 장점이 있습니다:
- 버전 정보가 중앙에서 관리되어 명확성이 높아집니다.
- CI/CD 파이프라인에서 버전을 자동으로 업데이트하기 용이해집니다.
- 여러 모듈에서 동일한 버전 정보를 참조해야 할 때 유용합니다.
version.properties 파일 예시:
VERSION_NAME=3.1.7
VERSION_CODE=45build.gradle.kts 적용 예시:
// build.gradle.kts 상단에 추가
val versionProps = java.util.Properties()
project.rootProject.file("version.properties").inputStream().use { versionProps.load(it) }
android {
defaultConfig {
// ...
versionCode = versionProps.getProperty("VERSION_CODE").toInt()
versionName = versionProps.getProperty("VERSION_NAME")
}
// ...
}
PeraSite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA의 중요성을 다시금 깨닫읍니다
다음부터는 성급하게 릴리즈 브랜치 pr을 닫지 않겠습니다🥲
변경 PR #414