-
Notifications
You must be signed in to change notification settings - Fork 0
[Fix] 최초 닉네임 설정시 발생하는 오류 해결 #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…exOutOfBoundsException 해결
Summary of ChangesHello @PeraSite, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 사용자 최초 닉네임 설정 과정에서 발생하는 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
이 PR은 최초 닉네임 설정 시 발생하는 IndexOutOfBoundsException을 해결합니다. 서버에서 내려주는 9글자 닉네임이 EditText의 maxLength인 8을 초과하여 발생하는 문제였습니다. coerceAtMost(8)을 사용하여 커서 위치를 제한하는 방식으로 문제를 해결하셨습니다. 올바른 수정이지만, 코드의 유지보수성을 높이기 위한 제안을 리뷰에 남겼습니다.
app/src/main/java/com/eatssu/android/presentation/mypage/userinfo/UserInfoActivity.kt
Outdated
Show resolved
Hide resolved
…nfo/UserInfoActivity.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
HI-JIN2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
빠른 대응 감사합니다 🙇♀️
해당 부분 담당하신 @kangyuri1114 님도 확인하시면 좋을 것 같아요!
기본 닉네임이 8자가 넘는다는건 인지하지 못했네요... 이건 규정 자체를 바꾸던, 기본 닉네임을 빠르게 바꾸던 해야할 것 같어요
|
확인했습니다. 오늘 진행할 86차 회의록에 닉네임을 어떻게 할 것인지 아젠다 올려놓아서 확실하게 결정하면 될 것 같아요! |
|
빠른대응 감사합니다! 확인했어요! |
Summary
Describe your changes
binding.etChNickname.setText(it.nickname)이전 이후를 로깅해보았는데, maxLength로 인해 user-251까지만 넣어지는 것을 확인했습니다.이전에는 앱을 키면 무조건 닉네임을 설정해주세요 라는 토스트와 함께 크래시가 발생했습니다.
https://console.firebase.google.com/u/0/project/eat-ssu-2023/crashlytics/app/android:com.eatssu.android/issues/e9b00d61b337c9f23b655b09f8a7a8c6?time=7d&types=crash&sessionEventKey=68E0B91A010500014FC2F75EBC31E3FE_2135689816230416376
Issue
To reviewers