[Feat] 리뷰 v2 전체 구현 #384
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| package com.eatssu.android.data.dto.request | ||
|
|
||
| import com.google.gson.annotations.SerializedName | ||
|
|
||
|
|
||
| data class WriteMealReviewRequest( | ||
| @SerializedName("mealId") var mealId: Long, | ||
| @SerializedName("rating") var rating: Int, | ||
| @SerializedName("menuLikes") var menuLikes: List<MenuLikes>? = arrayListOf(), | ||
| @SerializedName("content") var content: String? = null, | ||
| @SerializedName("imageUrls") var imageUrls: ArrayList<String>? = arrayListOf() | ||
| ) { | ||
| data class MenuLikes( | ||
| @SerializedName("menuId") var menuId: Long? = null, | ||
| @SerializedName("isLike") var isLike: Boolean? = null | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| package com.eatssu.android.data.dto.request | ||
|
|
||
| import com.google.gson.annotations.SerializedName | ||
|
|
||
| data class WriteMenuReviewRequest( | ||
| @SerializedName("menuId") var menuId: Long? = null, | ||
| @SerializedName("mainRating") var mainRating: Int? = null, | ||
| @SerializedName("amountRating") var amountRating: Int? = null, | ||
| @SerializedName("tasteRating") var tasteRating: Int? = null, | ||
| @SerializedName("content") var content: String? = null, | ||
| @SerializedName("imageUrl") var imageUrl: String? = null, | ||
| @SerializedName("menuLike") var menuLike: MenuLike? = MenuLike() | ||
| ) { | ||
| data class MenuLike( | ||
| @SerializedName("menuId") var menuId: Long? = null, | ||
| @SerializedName("isLike") var isLike: Boolean? = null | ||
| ) | ||
| } | ||
|
|
||
| //todo api 수정되면 다시 살리기 (추석이후 api 수정 예정) | ||
| //data class WriteMenuReviewRequest( | ||
| // @SerializedName("rating") var rating: Int? = null, | ||
| // @SerializedName("menuLikes") var menuLikes: List<MenuLikes> = arrayListOf(), | ||
| // @SerializedName("content") var content: String? = null, | ||
| // @SerializedName("imageUrls") var imageUrls: List<String> = arrayListOf() | ||
| // | ||
| //) { | ||
| // data class MenuLikes( | ||
| // @SerializedName("menuId") var menuId: Long? = null, | ||
| // @SerializedName("isLike") var isLike: Boolean? = null | ||
| // ) | ||
| //} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| package com.eatssu.android.data.dto.response | ||
|
|
||
| import com.eatssu.android.domain.model.Review | ||
| import com.google.gson.annotations.SerializedName | ||
|
|
||
| data class MealReviewListResponse( | ||
| @SerializedName("numberOfElements") var numberOfElements: Int? = null, | ||
| @SerializedName("hasNext") var hasNext: Boolean? = null, | ||
| @SerializedName("dataList") var dataList: ArrayList<DataList> = arrayListOf() | ||
| ) { | ||
| data class DataList( | ||
| @SerializedName("reviewId") var reviewId: Long? = null, | ||
| @SerializedName("menuList") var menuList: ArrayList<MenuList> = arrayListOf(), | ||
| @SerializedName("writerId") var writerId: Long? = null, | ||
| @SerializedName("isWriter") var isWriter: Boolean? = null, | ||
| @SerializedName("writerNickname") var writerNickname: String? = null, | ||
| @SerializedName("rating") var rating: Int? = null, | ||
| @SerializedName("writtenAt") var writtenAt: String? = null, | ||
| @SerializedName("content") var content: String? = null, | ||
| @SerializedName("imageUrls") var imageUrls: ArrayList<String> = arrayListOf(), | ||
| ) { | ||
| data class MenuList( | ||
| @SerializedName("id") var id: Long? = null, | ||
| @SerializedName("name") var name: String? = null, | ||
| @SerializedName("isLike") var isLike: Boolean? = null, | ||
| ) | ||
| } | ||
| } | ||
|
|
||
|
|
||
| fun MealReviewListResponse?.toDomain(): List<Review> { | ||
| // MealReviewListResponse 객체 자체가 null이면 emptyList() 반환 | ||
| return this?.dataList?.map { data -> | ||
| Review( | ||
| reviewId = data.reviewId ?: -1L, | ||
| isWriter = data.isWriter ?: false, | ||
| menuList = data.menuList.map { menu -> | ||
| Review.Menu( | ||
| menuId = menu.id ?: -1L, | ||
| name = menu.name ?: "", | ||
| isLike = menu.isLike ?: false | ||
| ) | ||
| }, | ||
| writerNickname = data.writerNickname ?: "유저", | ||
|
||
| rating = data.rating ?: 0, | ||
| writeDate = data.writtenAt ?: "", | ||
| content = data.content ?: "", | ||
| imgUrl = data.imageUrls.firstOrNull(), | ||
| ) | ||
| } ?: emptyList() | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,26 +1,20 @@ | ||
| package com.eatssu.android.data.dto.response | ||
|
|
||
| import com.google.gson.annotations.SerializedName | ||
|
|
||
| data class MenuOfMealResponse( | ||
| @SerializedName("menuList") var menuList: ArrayList<MenuList> = arrayListOf() | ||
| ) | ||
|
|
||
| data class MenuList( | ||
|
|
||
| @SerializedName("menuId") var menuId: Long? = null, | ||
| @SerializedName("name") var name: String? = null | ||
|
|
||
| ) | ||
|
|
||
| fun MenuOfMealResponse.toDomain(): List<Pair<Long, String>> { | ||
| return menuList.map { | ||
| (it.menuId ?: -1L) to (it.name ?: "") | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DTO(Data Transfer Object)의 속성은
var대신val로 선언하여 불변(immutable)으로 만드는 것이 좋습니다. 데이터 클래스는 일반적으로 상태를 가지지 않는 데이터 컨테이너로 사용되므로, 불변성을 유지하면 코드의 안정성과 예측 가능성을 높일 수 있습니다. 이 패턴은 다른 DTO 파일들(WriteMealReviewRequest.kt,WriteMenuReviewRequest.kt등)에도 동일하게 적용하는 것을 권장합니다.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
다른 request 확인해보니까 review 작성 관련 request만 var로 선언되어있는데 이유가 있을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그리고 다른 request는 default값이 없는데 리뷰 작성 request들만 default값이 있는 이유도 궁금합니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 생각해보니까 request면 디폴트값이나 nullable을 규제하는게 맞겠네여 수정해올게요..!
제가 별 생각 없이 작업한 것 같아요🥹