Skip to content

[Fix] 내 리뷰에서 사진이 안보이는 현상 고치기 및 null일때 디폴트값 처리 #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HI-JIN2 merged 5 commits into from
Sep 28, 2025
Merged

[Fix] 내 리뷰에서 사진이 안보이는 현상 고치기 및 null일때 디폴트값 처리 #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8f53d17
fix: 내 리뷰에서 사진이 안보이는 오류 수정
HI-JIN2 Sep 23, 2025
6f0567f
chore: null일때 기본값 처리
HI-JIN2 Sep 23, 2025
518ad38
chore: top bar "내리뷰"로 수정
HI-JIN2 Sep 23, 2025
1fcf420
Update app/src/main/java/com/eatssu/android/data/dto/response/MyRevie…
HI-JIN2 Sep 23, 2025
78e5358
Update app/src/main/java/com/eatssu/android/data/dto/response/MyRevie…
HI-JIN2 Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions app/src/main/java/com/eatssu/android/data/dto/response/MyReviewResponse.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,16 @@ data class MyReviewResponse(
fun MyReviewResponse.toReviewList(): List<Review> {
return dataList.map { data ->
Review(
reviewId = data.reviewId,
reviewId = data.reviewId ?: -1L,
isWriter = true,
menu = data.menuName,
menu = data.menuName ?: "",
writerNickname = "",
mainGrade = data.mainRating,
amountGrade = data.amountRating,
tasteGrade = data.tasteRating,
writeDate = data.writeDate,
content = data.content,
imgUrl = data.imgUrlList
mainGrade = data.mainRating ?: 0,
amountGrade = data.amountRating ?: 0,
tasteGrade = data.tasteRating ?: 0,
writeDate = data.writeDate ?: "",
content = data.content ?: "",
imgUrl = data.imgUrlList ?: arrayListOf(),
Copy link
Member

@kangyuri1114 kangyuri1114 Sep 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이미지를 하나만 올릴 수 있는걸로 알고 있었는데 리스트로 오는군요,,?
확장성을 위한 거였을까요? 궁금하네요..

Copy link
Member Author

@HI-JIN2 HI-JIN2 Sep 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리스트로 옵니다! 말씀하신대로 확장성을 위해서 리스트로 리뷰작성/리스트 둘다 리스트로 되어있는데, 운영 단에서 1장 이상일 필요 없다랑 S3 리소스 문제로 1장으로 운영하고 있슴다

)
}
}
18 changes: 10 additions & 8 deletions app/src/main/java/com/eatssu/android/presentation/mypage/myreview/MyReviewAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package com.eatssu.android.presentation.mypage.myreview
import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import android.widget.ImageView
import androidx.recyclerview.widget.DiffUtil
import androidx.recyclerview.widget.ListAdapter
import com.bumptech.glide.Glide
Expand Down Expand Up @@ -37,14 +36,17 @@ class MyReviewAdapter :
binding.tvMenuName.text = data.menu
binding.rbRate.rating = data.mainGrade.toFloat()

val imageView: ImageView = binding.ivReviewPhoto
if (data.imgUrl?.isEmpty() == true || data.imgUrl?.get(0).isNullOrEmpty()) {
imageView.visibility = View.GONE
} else {
val firstImageUrl = data.imgUrl?.firstOrNull()

if (!firstImageUrl.isNullOrEmpty()) {
Glide.with(itemView)
.load(data.imgUrl?.get(0))
.into(imageView)
imageView.visibility = View.VISIBLE
.load(firstImageUrl)
.into(binding.ivReviewPhoto)
binding.ivReviewPhoto.visibility = View.VISIBLE
binding.cvPhotoReview.visibility = View.VISIBLE
} else {
binding.ivReviewPhoto.visibility = View.GONE
binding.cvPhotoReview.visibility = View.GONE
}

binding.btnDetail.setOnClickListener { v: View ->
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/com/eatssu/android/presentation/mypage/myreview/MyReviewListActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class MyReviewListActivity :

override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
toolbarTitle.text = "내가 쓴 리뷰" // 툴바 제목 설정
toolbarTitle.text = "내 리뷰" // 툴바 제목 설정

loadReview()
}
Expand Down