Skip to content

[Chore] 닉네임이 "user-"로 시작하면 닉네임 설정화면으로 이동하게 수정 #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HI-JIN2 merged 1 commit into from
Sep 16, 2025
Merged

[Chore] 닉네임이 "user-"로 시작하면 닉네임 설정화면으로 이동하게 수정 #353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions app/src/main/java/com/eatssu/android/presentation/MainViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ import androidx.lifecycle.ViewModel
import androidx.lifecycle.viewModelScope
import com.eatssu.android.R
import com.eatssu.android.domain.repository.UserRepository
import com.eatssu.android.domain.usecase.user.GetUserNickNameUseCase
import com.eatssu.android.domain.usecase.auth.LogoutUseCase
import com.eatssu.android.domain.usecase.user.GetUserCollegeDepartmentUseCase
import com.eatssu.android.domain.usecase.user.GetUserNickNameUseCase
import com.eatssu.android.domain.usecase.user.SetUserCollegeDepartmentUseCase
import dagger.hilt.android.lifecycle.HiltViewModel
import dagger.hilt.android.qualifiers.ApplicationContext
Expand Down Expand Up @@ -42,12 +42,9 @@ class MainViewModel @Inject constructor(
private val _uiEvent = MutableSharedFlow<UiEvent>()
val uiEvent: SharedFlow<UiEvent> = _uiEvent

// init {
// checkNameNull()
// } 얘 떄문에 두번씩 처리됨.

init {
getUserDepartment()
fetchAndCheckNickname()
}

fun refreshUserDepartment() {
Expand All @@ -72,7 +69,7 @@ class MainViewModel @Inject constructor(
result.result?.let { userInfo ->
val nickname = userInfo.nickname

if (nickname.isNullOrBlank()) {
if (nickname.isNullOrBlank() || nickname.startsWith("user-")) {
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

하드코딩된 문자열 "user-"를 상수로 정의하여 사용하는 것을 권장합니다. 이렇게 하면 나중에 접두사가 변경될 경우 한 곳에서만 수정하면 되므로 유지보수성이 향상됩니다.

MainViewModel 클래스 내에 companion object를 추가하여 상수를 정의할 수 있습니다.

companion object {
    private const val DEFAULT_NICKNAME_PREFIX = "user-"
}

그런 다음 이 상수를 코드에서 사용하세요.

Suggested change
if (nickname.isNullOrBlank() || nickname.startsWith("user-")) {
if (nickname.isNullOrBlank() || nickname.startsWith(DEFAULT_NICKNAME_PREFIX)) {

_uiState.value = UiState.Success(MainState.NicknameNull)
_uiEvent.emit(UiEvent.ShowToast(context.getString(R.string.set_nickname)))
return@let
Expand Down