[Feat] 리뷰 v2 #304
Closed
[Feat] 리뷰 v2 #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HI-JIN2
force-pushed
the
feat/review-v2-ui
branch
from
4fb90fc to
0b50e78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
리뷰 v2 구현은 jetpack compose로 했습니다.
Describe your changes
위에 두 파일 날리고, 아래 3 파일 살리면 됩니다.
이 PR이 병합되어도 당장 리뷰 v2가 적용되지 않습니다. intent에 넘겨주는 클래스명을 안바꿨거든요.
activity 안에 screen 구현 한거라서, 현재 xml 동작과 껍데기가 유사합니다.
Issue
To reviewers
import com.google.gson.annotations.SerializedName의 경우, 서버쪽이랑 네이밍 규칙이 다를 때 쓰는걸로 알고 있습니다. 하지만 같은 camelCase를 쓰고 있기 때문에(자바와 코틀린), 규칙이 안맞을 경우가 없습니다. 그래서 불필요하다고 생각해서 제거하였습니다. 제거 해도 잘 돌아갑니다.리뷰V2에서 쓰이는 component들을 분리했습니다. compose의 장점을 살리려 분리했고, 모듈화까지 이어졌으면 좋겠습니다.