[Feat] bottom Navigation 도입 #283
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… activityviewmodel 사용을 위한 라이브러리 추가 및 프래그먼트용 토스트 확장 함수 생성.
…으나 메뉴 프래그먼트가 보이지 않음.
* add: bottomSheetDialogFragment * refactor: ListAdapter로 변경 * change: bottomSheet clickListener * chore: 전체 리뷰에서 삭제하면 리스트 재호출 안되는거 수정 * chore: 전체 리뷰에서 삭제하면 리스트 재호출 안되는거 수정 * chore: 왼쪽 정렬, 워딩 수정 "리뷰 설정" * chore: 오탈자 수정 * chore: apply로 바로 받아서 쓰기
Member
|
일단 main 패키징은 필요 없을 것 같아용 유리님과 패키징이랑 모듈화에 대해서 이야기 해보고 싶습니다! |
# Conflicts: # app/src/main/AndroidManifest.xml # app/src/main/res/values/strings.xml
Member
Author
|
@HI-JIN2 리뷰를 이제 봤네요 ㅠ 이후 pr에 반영해두도록 할게요 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Describe your changes
Issue
To reviewers