Rfe/simplify (Do NOT merge) #1215
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO not Merge, create a new branch and let's synch. Or better yet, give me collab permisions and we work on a branch together, it simplifies stuff.
Notes added in README.md
Collaboration notes & todos
Documentation:
[ ] - Simplify documentation. Maybe add MKdocs? to have better user UX
[ ] - Explain what this repo is about, documentation about new usecases, problem patterns. Point to the sourcecode where the helm charts are pointing to.
[ ] - Add step by step doc, simplify options, use as default CNFS with only 3 vars, Environment URL, Ingest and Operator tokens.
Repository changes:
[x] - Renaming to DT_OTEL_ENDPOINT and DT_INGEST_TOKEN of dt-secrets to keep consistency and avoid missinterpretations.
[ ] - Enable frontend-proxy. Have this by default, fix missing images, envoy of different services, flagd, etc
[ ] - Enhance deploy script to run automatically on 1 run, fail if vars are not defined.
[y] - Deploy script (in framework code) - clone to this repo later
[y] - helm repo add, update, builds
[y] - check/install Kustomize
[y] - helm upgrade with env vars so they are not stored in YAML
[] - Flagd - expose Flagd-UI so Users can change the Problem Patterns easily.
[] - UI explsed as side car in the helm values,
[] - SECRET_KEY_BASE added in base 64
[] - flagd-ui service added so it can be properly exposed in envoy
Issue was that the envoy.yaml in the frontend-proxy has a flad-ui cluster defined but there is no endpoint for it, the flagdui is exposed as sidecar in the flagd service
[X] - Loadtest scaled down to 1 replica having 2 users, no problems detected on Kind
[X] - Fraud Detection Memory Limits raised to 512Mi
[X] - Active Gate Limits raised to 1 Gig (maybe use 2?)
Envoy troubleshoot
Check clusters
kubectl port-forward -n astroshop frontend-proxy-594968df69-8jmpk 10000:10000
curl http://localhost:10000/clusters | grep fladg