Remove unused functions in prepare-build-variables.sh script

[aorcholski]

DAQ-12536

Description

This PR removes unused functions from the prepare-build-variables.sh script. The script is also removed from the CI workflow.

I added metadata action to keep the tags logic in one place. It returns both values provided by docker/metada-action:

tags 	    String 	Docker tags
tag-names 	String 	Docker tag names without image base name

Sanitized names are used in the tags logic because CVS parser called by docker/metada-action skips all characters after # (it is a comment).

How can this be tested?

I used forked repo. I created new workflow based on the CI one that pushes images to a different registry. I was able to compare images.

[Incredible-O]

Nit: Could you please remove this newline?

Suggested change

[Incredible-O]

Suggested change

[Copilot]

Pull request overview

This PR removes unused functions and workflow steps from the CI build process by consolidating Docker image metadata generation into a reusable action. The changes eliminate the deprecated prepare-build-variables.sh script and its associated workflow job, replacing them with a new metadata action that centralizes tag and label generation logic.

Key changes:

• Removed unused create_docker_image_labels() function and related output variables from prepare-build-variables.sh
• Eliminated the prepare job from the CI workflow
• Created a new reusable metadata action that generates Docker image metadata including tags, labels, and annotations

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
hack/build/ci/prepare-build-variables.sh	Removed unused create_docker_image_labels() function and related variable assignments
.github/workflows/ci.yaml	Removed the prepare job and updated preflight-main to use new action inputs
.github/actions/preflight/action.yaml	Refactored to use the new metadata action instead of separate version/registry/repository inputs
.github/actions/metadata/action.yaml	New reusable action that consolidates Docker metadata generation with sanitized branch names
.github/actions/build-push-image/action.yaml	Integrated the new metadata action and simplified the build process

[Copilot]

For tags, the original logic in create_docker_image_tag() returns github.ref_name directly without stripping the 'v' prefix. This new implementation strips the prefix unconditionally, which changes the tag format for version tags and may break existing references or tooling that expects tags to include the 'v' prefix.

Suggested change

	type=raw,value=${{ steps.sanitize.outputs.ref_name_without_prefix }},enable=${{ github.ref_type == 'tag' }}
	type=raw,value=${{ steps.sanitize.outputs.ref_name }},enable=${{ github.ref_type == 'tag' }}

[Copilot]

The create_go_linker_args.sh script is being passed tag-names (which contains multiple comma-separated tags without the image base name) instead of a single tag value. The original code passed docker_image_tag from create_docker_image_tag(), which was a single tag string. This may cause the linker args script to fail or produce incorrect version information.

Suggested change

	go_linker_args=$(hack/build/create_go_linker_args.sh "${{ steps.meta.outputs.tag-names }}" "${{ github.sha }}")
	go_linker_args=$(hack/build/create_go_linker_args.sh "${{ steps.meta.outputs.tag }}" "${{ github.sha }}")

[aorcholski]

create_go_linker_args.sh script needs tag without the image base name so it should be value of tag-names .