Skip to content

Conversation

@avorima
Copy link
Contributor

@avorima avorima commented Nov 28, 2025

Description

I added the deploy/image-ref target to be fully compatible with make deploy, otherwise the image would not match in most cases.

DAQ-14405

How can this be tested?

Run any e2e test and see if the chart is installed correctly.

Test run: https://github.com/Dynatrace/dynatrace-operator/actions/runs/19765900821/job/56638503176

Copy link
Contributor

@andriisoldatenko andriisoldatenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick test on GKE, and it works!

@avorima
Copy link
Contributor Author

avorima commented Dec 1, 2025

Verify the format fix:

.github/workflows/test.yml

name: Test format
on:
  pull_request:
  workflow_dispatch:
    inputs:
      target:
        description: Target
        required: true
        default: 'main'
jobs:
  test:
    runs-on: ubuntu-latest
    steps:
      - run: echo $MYVAR
        env:
          MYVAR: ${{ format('{0}-fips', github.event.inputs.target || 'main') }}
act pull_request -W .github/workflows/test.yml
act workflow_dispatch --input target=foo -W .github/workflows/test.yml

@avorima avorima enabled auto-merge (squash) December 11, 2025 13:41
@avorima avorima merged commit 8d76550 into main Dec 11, 2025
18 checks passed
@avorima avorima deleted the e2e-test-helm-deploy branch December 11, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants