-
Notifications
You must be signed in to change notification settings - Fork 162
[WIP] Build operator image from single source of truth using FIPS-140-3 #5747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
avorima
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can consolidate a bit here. Special make targets for fips can be removed in favor of making the mode fully dependent on the env/args. The same goes for workflows. fips-ci and fips-release are very similar to their non-fips counterparts
potentially yes, but it requires more work and testing, okey let me do it :) |
4cc1fb3 to
f90942b
Compare
9a1e1c2 to
ded6429
Compare
# Conflicts: # .github/workflows/fips-ci.yaml
Co-authored-by: aorcholski <[email protected]>
Co-authored-by: Mario Valderrama <[email protected]>
8ab7657 to
61fa8bc
Compare
6345f5f to
ab5f66b
Compare
Description
This PR resolves https://dt-rnd.atlassian.net/browse/DAQ-11573
Note
- fixed how we run e2e tests using ocp fips cluster and fips image (we broke it for a while and run normal image using FIPS cluster)fixed by @avorima in another PRFIPS 140-2 Mode Enabled: true/falsewhen we start operator/webhook to easily find which one we use currentlyWarning
In testing phase, potentially postponed until Go 1.26 release.
How can this be tested?
run e2e tests with/ using FIPS and non FIPS image.