feat(document): remove external ID usage and support deletefile for custom ID #2079
+55
−138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a custom ID is set, the direct reference (type and objectId) should be used for the delete file
… an ID The external ID should be treated as an ID. Therefore, the delete doesn't filter the documents based on the externalID anymore and just tries to delete a document via the external ID.
Kirdock
force-pushed
the
feat/document/correctly-handle-custom-id-for-delete
branch
from
a4fbf13 to
1610c78
Compare
|
d0weinberger
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
The externID is deprecated, and it should be possible to delete a document with a custom set ID.
What has changed?
How does it do it?
How is it tested?
New tests added that validate the generated deletefile
How does it affect users?
Currently, it doesn't affect users. The customID is not released in Moanco yet. There is just a slightly different error message if the deletion via externalID didn't work.
Issue: CA-16614