DYN-9965: Change in PythonNet3 syntax #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for review only and is related to DYN-9965.
It adds a small compatibility shim to the PythonNet3 evaluator to keep some legacy instance-style calls on
ConnectionNodeworking.Some Advance Steel APIs expose static methods (
SubNodesOfSizeandExistingConnections) . The older CPython3 engine allowed these methods to be called as if they were instance methods. PythonNet3 is stricter and no longer allows this, which causes some existing graphs to fail.The shim patches
ConnectionNodeinstances by attaching small wrapper functions that forward instance-style calls to the correct static methods. This restores the old behavior without changing the underlying API or affecting valid static calls.There may be other static methods affected by the same change. However, applying a global fix would be risky, as it could wrap unintended members or change overload resolution in unpredictable ways. If more cases are found, the safest approach would be to add them to a small, explicit patch list based on real failures.
@zeusongit