-
Notifications
You must be signed in to change notification settings - Fork 666
Fix bug with dependency load DynamoUtilities #16749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix bug with dependency load DynamoUtilities #16749
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a dependency loading bug in DynamoUtilities that causes the splash screen to fail in debug mode when running without a full solution rebuild. The fix adds a missing project reference to DynamoFeatureFlags, resolving an unhandled exception that occurred when DynamoUtilities attempted to interact with DynamoFeatureFlags without the proper build dependency in place.
Key Changes:
- Added missing project reference to DynamoFeatureFlags in DynamoUtilities.csproj
|
Do we know, when did this start happening, what caused this? |
The error occurs when the DynamoUtilities project, which launches DynamoFeatureFlags, attempts to call DynamoFeatureFlags.exe. However, since DynamoFeatureFlags.exe hasn't been compiled at the time of the call because the DynamoUtilities project doesn't depend on DynamoFeatureFlags having been compiled beforehand, it can't find the .exe file. But if you run |
|
I wouldn’t make this change and complicate dependencies between projects for what is only developer convenience. its important that assemblies like dyn utils and services have as few deps as possible. Either add a null check or move the method. is it very common during the normal course of development that feature flags will not already be built or that you wouldn’t build the entire solution anyway? |
You are right; however, from my point of view, it is expensive to add a null check before using the assembly in the different places where it is used. When adding the dependency, we avoid additional checks. We could consider moving the method, but what is the impact of it? |
Purpose
The Splash screen loading fails in debug mode if the solution is running without rebuilding the entire solution. Currently, the solution throws an unhandled exception. The failure occurs when the DynamoUtilities sends the request to the DynamoFeatureFlags component without building it.
DynamoVideo.mp4
Declarations
Check these if you believe they are true
Release Notes
The DynamoUtilities dependency loading bug was fixed by adding the missing reference (DynamoFeatureFlags).
Reviewers
@chubakueno
FYIs