-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Use pydantic 1.10 due to homeassistant incompatibility with pydantic>2.0 #269
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #269 +/- ##
==========================================
- Coverage 75.33% 72.46% -2.87%
==========================================
Files 27 28 +1
Lines 1277 1351 +74
==========================================
+ Hits 962 979 +17
- Misses 315 372 +57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @GitOldGrumpy. Since @DurgNomis-drol seems to be quite busy and inactive here lately; Could you approve this MR without maintainer rights? |
Afraid I dont have such options, maybe if you can add me to the list of reviewers I will have such an option? |
Unfortunately not. Looks like I can only request a review from maintainers. :-/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ❤️
There is currently an error when trying to use the latest
mytoyota
version under a Homeassistant env.This is apparently due to the
pydantic>=2.0.
incompatibility of some of the packages included in Homeassitant.We should therefore also use
pydantic=1.10
as the maximum version for the time being.We should switch back to pydantic >= 2.0 as soon as the issue on home assistant side is resolved: home-assistant/core#99218