Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Modifier issues on the iosMain side of the code have been addressed. #743

Conversation

Corvus400
Copy link
Contributor

@Corvus400 Corvus400 commented Aug 22, 2024

Issue

Overview (Required)

  • The :core:ui module has been renamed to :core:droidkaigiui.
  • This change resolves issues where iosMain could not correctly reference Modifier and other components due to naming conflicts.

Issue Details

  • The original :core:ui module name was too generic, leading to naming conflicts within the Kotlin Multiplatform project.

  • These conflicts occurred because the KLIB resolver detected multiple libraries with the same name, making it difficult to determine which library to use, resulting in build or runtime errors.

  • This issue is related to KT-66568, where the KLIB resolver fails to function correctly due to such naming conflicts.

Solution

  • By renaming the module from :core:ui to :core:droidkaigiui, we avoided the naming conflict and allowed the KLIB resolver to correctly identify the appropriate libraries. As a result, iosMain can now successfully reference Modifier and other components, resolving the issue.

  • Thanks to @Aniokrait for providing specific ways to respond! 👏

Links

…bug/fix_build_failes_just_compile_modifier_problem
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 23, 2024 09:51 Inactive
@takahirom
Copy link
Member

takahirom commented Aug 23, 2024

Can we have a README in core/droidkaigiui/README.md ?

# core/ui
It seems that the name `ui` conflicts with Compose UI in the iOS app. Therefore, we need to use droidkaigiui instead.
Please check https://github.com/DroidKaigi/conference-app-2024/issues/485 for more information.

@takahirom takahirom added the awesome Label for project-applicable insights or remarkable technologies. label Aug 23, 2024
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 23, 2024 10:12 Inactive
@takahirom
Copy link
Member

@Corvus400 Can you make this PR ready?🙏

@Corvus400 Corvus400 marked this pull request as ready for review August 23, 2024 10:48
Copy link

Detekt check failed. Please run ./gradlew detekt --auto-correct to fix the issues.

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 23, 2024 18:36 Inactive
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 23, 2024 21:53 Inactive
@takahirom
Copy link
Member

@Corvus400 Sorry, could you please solve the conflict? 🙏

…bug/fix_build_failes_just_compile_modifier_problem

# Conflicts:
#	app-android/src/main/java/io/github/droidkaigi/confsched/KaigiApp.kt
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 24, 2024 03:02 Inactive
…bug/fix_build_failes_just_compile_modifier_problem

# Conflicts:
#	app-ios-shared/src/commonMain/kotlin/io/github/droidkaigi/confsched/shared/IosComposeKaigiApp.kt
@takahirom
Copy link
Member

Let's merge this without waiting for the CI to get out of conflict hell

@takahirom takahirom merged commit c83399c into DroidKaigi:main Aug 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awesome Label for project-applicable insights or remarkable technologies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Modifier problem] Bug, Build fails to kover on just compile.
2 participants