-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 Modifier issues on the iosMain side of the code have been addressed. #743
Merged
takahirom
merged 10 commits into
DroidKaigi:main
from
Corvus400:bug/fix_build_failes_just_compile_modifier_problem
Aug 24, 2024
Merged
🔧 Modifier issues on the iosMain side of the code have been addressed. #743
takahirom
merged 10 commits into
DroidKaigi:main
from
Corvus400:bug/fix_build_failes_just_compile_modifier_problem
Aug 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bug/fix_build_failes_just_compile_modifier_problem
Can we have a README in core/droidkaigiui/README.md ?
|
takahirom
added
the
awesome
Label for project-applicable insights or remarkable technologies.
label
Aug 23, 2024
@Corvus400 Can you make this PR ready?🙏 |
Detekt check failed. Please run |
@Corvus400 Sorry, could you please solve the conflict? 🙏 |
…bug/fix_build_failes_just_compile_modifier_problem # Conflicts: # app-android/src/main/java/io/github/droidkaigi/confsched/KaigiApp.kt
…bug/fix_build_failes_just_compile_modifier_problem # Conflicts: # app-ios-shared/src/commonMain/kotlin/io/github/droidkaigi/confsched/shared/IosComposeKaigiApp.kt
Let's merge this without waiting for the CI to get out of conflict hell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
:core:ui
module has been renamed to:core:droidkaigiui
.iosMain
could not correctly referenceModifier
and other components due to naming conflicts.Issue Details
The original
:core:ui
module name was too generic, leading to naming conflicts within the Kotlin Multiplatform project.These conflicts occurred because the KLIB resolver detected multiple libraries with the same name, making it difficult to determine which library to use, resulting in build or runtime errors.
This issue is related to KT-66568, where the KLIB resolver fails to function correctly due to such naming conflicts.
Solution
:core:ui
to:core:droidkaigiui
, we avoided the naming conflict and allowed the KLIB resolver to correctly identify the appropriate libraries. As a result,iosMain
can now successfully referenceModifier
and other components, resolving the issue.Links