Skip to content

Fix entities not rendering when Identity menu is opened #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SistrScarlet wants to merge 1 commit into
base: arch-1.19
Choose a base branch
from
Open

Fix entities not rendering when Identity menu is opened #512

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions common/src/main/java/draylar/identity/screen/widget/EntityWidget.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
import net.minecraft.client.gui.screen.ingame.InventoryScreen;
import net.minecraft.client.gui.screen.narration.NarrationMessageBuilder;
import net.minecraft.client.gui.widget.PressableWidget;
import net.minecraft.client.render.DiffuseLighting;
import net.minecraft.client.render.VertexConsumerProvider;
import net.minecraft.client.render.entity.EntityRenderDispatcher;
import net.minecraft.client.util.math.MatrixStack;
import net.minecraft.entity.LivingEntity;
import net.minecraft.text.Text;
Expand All @@ -26,6 +29,7 @@ public class EntityWidget<T extends LivingEntity> extends PressableWidget {
private boolean active;
private boolean starred;
private final IdentityScreen parent;
private boolean crashed;

public EntityWidget(float x, float y, float width, float height, IdentityType<T> type, T entity, IdentityScreen parent, boolean starred, boolean current) {
super((int) x, (int) y, (int) width, (int) height, Text.of("")); // int x, int y, int width, int height, message
Expand Down Expand Up @@ -75,12 +79,20 @@ else if(button == 1) {
public void render(MatrixStack matrices, int mouseX, int mouseY, float delta) {
super.render(matrices, mouseX, mouseY, delta);

// Some entities (namely Aether mobs) crash when rendered in a GUI.
// Unsure as to the cause, but this try/catch should prevent the game from entirely dipping out.
try {
InventoryScreen.drawEntity(x + this.getWidth() / 2, (int) (y + this.getHeight() * .75f), size, -10, -10, entity);
} catch (Exception ignored) {

if(!crashed) {
// Some entities (namely Aether mobs) crash when rendered in a GUI.
// Unsure as to the cause, but this try/catch should prevent the game from entirely dipping out.
try {
InventoryScreen.drawEntity(x + this.getWidth() / 2, (int) (y + this.getHeight() * .75f), size, -10, -10, entity);
} catch (Exception ignored) {
crashed = true;
VertexConsumerProvider.Immediate immediate = MinecraftClient.getInstance().getBufferBuilders().getEntityVertexConsumers();
immediate.draw();
EntityRenderDispatcher entityRenderDispatcher = MinecraftClient.getInstance().getEntityRenderDispatcher();
entityRenderDispatcher.setRenderShadows(true);
RenderSystem.getModelViewStack().pop();
DiffuseLighting.enableGuiDepthLighting();
}
}

// Render selected outline
Expand Down