update

Fixed Young Status Not removing off characters. Fixed Wrong Order DFN Tags in ssection.h
DragonSlayer62 · Feb 1, 2025 · 73a8223 · 73a8223
1 parent a967481
commit 73a8223
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 13 deletions.
diff --git a/data/js/player/young_player.js b/data/js/player/young_player.js
@@ -226,6 +226,19 @@ function RevokeYoungStatus( pSock, pChar, revokeReason )
 	pSock.SysMessage( revokeReason );
 	pSock.SysMessage( GetDictionaryEntry( 18704, pSock.language )); // You are no longer considered a young player of Ultima Online, and are no longer subject to the limitations and benefits of being in that caste.
 	pChar.account.isYoung = false;
+	var playerAccount = pChar.account;
+	for( var i = 1; i <= 7; i++ )
+	{
+		// Construct the property name, e.g., "character1", "character2", etc.
+		var charKey = "character" + i;
+		var tempChar = playerAccount[charKey];
+
+		// Validate the character object before performing any actions
+		if( ValidateObject( tempChar ))
+		{
+			tempChar.RemoveScriptTrigger( 8001 );
+		}
+	}
 	pChar.Refresh();
 }
 

diff --git a/source/ssection.h b/source/ssection.h
@@ -60,7 +60,6 @@ enum DFNTAGS
 	DFNTAG_CREATOR,
 	DFNTAG_CUSTOMSTRINGTAG,
 	DFNTAG_CUSTOMINTTAG,
-	DFNTAG_DURABILITYHPBONUS,
 	DFNTAG_DAMAGE,
 	DFNTAG_DAMAGEABLE,
 	DFNTAG_DECAY,
@@ -73,10 +72,11 @@ enum DFNTAGS
 	DFNTAG_DISPELLABLE,
 	DFNTAG_DISABLED,
 	DFNTAG_DOORFLAG,
-	DFNTAG_DEFENSECHANCE,
+	DFNTAG_DURABILITYHPBONUS,
 	DFNTAG_DYE,
 	DFNTAG_DYEBEARD,
 	DFNTAG_DYEHAIR,
+	DFNTAG_DEFENSECHANCE,
 	DFNTAG_ELEMENTRESIST,
 	DFNTAG_ERBONUS,
 	DFNTAG_EMOTECOLOUR,

diff --git a/source/uox3.cpp b/source/uox3.cpp
@@ -2724,26 +2724,25 @@ auto CWorldMain::CheckAutoTimers() -> void
 			{
 				auto uChar = static_cast<CChar *>( entry.first );
 
-                // Let's ensure we only do one stat window update for self per cycle,
-                // by skipping subsequent updates if it has already been updated
-				bool skipStatWindowUpdate = false;
+				// Let's ensure we only do one stat window update for self per cycle,
+				bool triggerStatWindowUpdate = false;
 
 				if( uChar->GetUpdate( UT_HITPOINTS ))
 				{
-					UpdateStats( entry.first, 0, skipStatWindowUpdate );
-					skipStatWindowUpdate = true;
+					triggerStatWindowUpdate = true;
+					UpdateStats( entry.first, 0, false );
 				}
 				if( uChar->GetUpdate( UT_STAMINA ))
 				{
-					UpdateStats( entry.first, 1, skipStatWindowUpdate );
-					skipStatWindowUpdate = true;
+					triggerStatWindowUpdate = true;
+					UpdateStats( entry.first, 1, false );
 				}
 				if( uChar->GetUpdate( UT_MANA ))
 				{
-					UpdateStats( entry.first, 2, skipStatWindowUpdate );
-					skipStatWindowUpdate = true;
+					triggerStatWindowUpdate = true;
+					UpdateStats( entry.first, 2, false );
 				}
-
+				
 				if( uChar->GetUpdate( UT_LOCATION ))
 				{
 					uChar->Teleport();
@@ -2761,7 +2760,7 @@ auto CWorldMain::CheckAutoTimers() -> void
 				{
 					uChar->Update();
 				}
-				else if( uChar->GetUpdate( UT_STATWINDOW ) && !skipStatWindowUpdate )
+				else if( uChar->GetUpdate( UT_STATWINDOW ) || triggerStatWindowUpdate )
 				{
 					CSocket *uSock = uChar->GetSocket();
 					if( uSock )