Merge pull request UOX3DevTeam#221 from danielshoun/bod-reward-errors

Fixes to Blacksmithing BOD Reward Items.
DragonSlayer62 · Nov 11, 2023 · 71b4f9b · 71b4f9b
2 parents 467a036 + 62dc86f
commit 71b4f9b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/data/js/item/equip_effects/skill_boosting_equipment.js b/data/js/item/equip_effects/skill_boosting_equipment.js
@@ -21,10 +21,10 @@ function onEquip( pEquipper, iEquipped )
 	switch( skillBonusID )
 	{
 		case 7: // Blacksmithing
-			pEquipper.baseskills.blacksmithing += skillBonusVal;
+			pEquipper.skills.blacksmithing += skillBonusVal;
 			break;
 		case 45: // Mining
-			pEquipper.baseskills.mining += skillBonusVal;
+			pEquipper.skills.mining += skillBonusVal;
 			break;
 		default:
 			break;
@@ -39,10 +39,10 @@ function onUnequip( pUnquipper, iUnequipped )
 	switch( skillBonusID )
 	{
 		case 7: // Blacksmithing
-			pUnquipper.baseskills.blacksmithing -= skillBonusVal;
+			pUnquipper.skills.blacksmithing -= skillBonusVal;
 			break;
 		case 45: // Mining
-			pUnquipper.baseskills.mining -= skillBonusVal;
+			pUnquipper.skills.mining -= skillBonusVal;
 			break;
 		default:
 			break;

diff --git a/data/js/npc/ai/vendor_bdo_dispenser.js b/data/js/npc/ai/vendor_bdo_dispenser.js
@@ -694,17 +694,17 @@ function DispenseBODRewards( pDropper, npcDroppedOn, iDropped )
 		minReward = 0 + minMaxMod[0];
 		maxReward = 16 + minMaxMod[1];
 
-		switch( WeightedRandom( minReward, maxReward, weightVal ))
+		switch( WeightedRandom( minReward, maxReward, weightVal ) )
 		{
 			case 0: // Sturdy Pickaxe / Sturdy Shovel (equal chance)
-				switch( RandomNumber( 0, 1 ))
+				switch( RandomNumber( 0, 1 ) )
 				{
 					case 0: // Sturdy Pickaxe
 						bodRewardItem = CreateBODReward( 0, socket, pDropper, 0 );
 						break;
 					case 1: // Sturdy Shovel
-						break;
 						bodRewardItem = CreateBODReward( 1, socket, pDropper, 0 );
+						break;
 					default:
 						break;
 				}