feat(net): [WIP] 桥接网络支持 #1287
feat(net): [WIP] 桥接网络支持 #1287
Conversation
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
- Removed the default_iface parameter. - Introduced a new NAPI module to manage network polling and scheduling. - Updated the Iface trait to include a napi_struct method for NAPI support. - Modified Veth network interfaces to integrate with the new NAPI structure. - Refactored the Router implementation to remove unnecessary polling threads and wait queues. - Updated NetNamespace to manage a list of bridge devices. - Cleaned up various unused methods and comments across network-related files. Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
Signed-off-by: sparkzky <[email protected]>
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| // 或者需要遍历 reverse_mappings 找到 value 为 key 的条目并删除。 | ||
| // 为简单起见，这里只清理主表。更健壮的实现需要双向链接或引用计数。 | ||
| log::info!("Cleaned up expired connection for key: {:?}", key); | ||
| } |
There was a problem hiding this comment.
Bug: Time Travel Bug and Memory Leak
The cleanup_expired method has two issues: duration_since().unwrap() can panic if mapping.last_seen() is in the future relative to now, and it causes a memory leak by only cleaning the mappings table, leaving reverse_mappings with stale entries.
|
|
||
| let chunks = unsafe { from_raw_parts(byte_buffer.as_ptr() as *const T, 1) }; | ||
| let data = &chunks[0]; | ||
| return Ok(data); |
There was a problem hiding this comment.
Bug: Unsafe Cast and Excessive Logging
The convert_one_from_raw_buf function performs an unsafe cast from a byte slice to &T without verifying proper alignment for type T. This can lead to undefined behavior, crashes, or data corruption. Separately, a log::info! statement in this function will cause excessive logging in production.
| .inner | ||
| .lock() | ||
| .bridge_common_data | ||
| .as_ref() |
There was a problem hiding this comment.
Bug: Weak Reference Upgrade Panic
The recv_from_peer method panics if its self_iface_ref weak reference has been dropped. Calling upgrade().unwrap() on a Weak reference can lead to a crash if the underlying VethInterface is no longer alive.
此PR为OSPP-DragonOS 桥接网络支持
已实现：
待补充：