Skip to content

fix(credentials): read the macOS keychain without an invalid target #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
7smd7 wants to merge 1 commit into from
Closed

fix(credentials): read the macOS keychain without an invalid target #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/modules/antigravity-runtime/credentials/antigravityCredentialStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,11 +167,11 @@ function classifyCredentialStoreReadError(error: unknown): CredentialStoreReadEr
}

function createNativeCredentialEntry(): Entry {
// Secret Service interprets an explicit target as a collection name. The
// Windows credential target must not create a new Linux collection/prompt.
return process.platform === 'linux'
? new Entry('gemini', 'antigravity')
: Entry.withTarget('gemini:antigravity', 'gemini', 'antigravity');
// Only macOS and Linux reach the native keyring; Windows uses the
// `gemini:antigravity` credential target directly. Do not pass that target to
// `Entry.withTarget`: macOS expects a keychain kind (`User` / `System` /
// `Common` / `Dynamic`) and Secret Service treats it as a collection name.
return new Entry('gemini', 'antigravity');
}

function readViaNativeKeyring(): Uint8Array | null {
Expand Down
3 changes: 3 additions & 0 deletions src/tests/unit/antigravity-credential-store-read.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,9 @@ describe('readAntigravityCredentialStoreToken', () => {
expect(await readAntigravityCredentialStoreToken()).toEqual({
refreshToken: 'refresh-macos',
});
// The macOS keyring rejects any target other than a keychain kind.
expect(mocks.createEntry).toHaveBeenCalledWith('gemini', 'antigravity');
expect(mocks.withTarget).not.toHaveBeenCalled();
});

it('uses the bounded Linux secret-tool fallback after native keyring failure', async () => {
Expand Down
Loading