Add method to specify the output sample rate - #9
Conversation
|
I think it is fine to just have it as separate function for now So this PR is fine as it is
I do not really see much value to it as these values are basically constants you to use as enums You can make PR to introduce enum that gets converted into |
I agree. I thought you might prefer it since the |
Ah it might, I do not remember now much, but I think I added Bitrate enum because there was quite a lot of allowed values so I wanted to make sure I do not make mistake with units Sample rate at least a bit more easier as there small range of values |
|
Thanks, I'll release new version soon |
|
@ginnyTheCat I released 0.2.3 |
I made the function accept a
Option<NonZeroU32>, but I would be open to replace it with a enum of the 9 accepted values.Additionally to this change I have 3 possible options + pseudocode, that I'm unsure which one would be best for the future: