Mr.Mulles TPP freecam config

[SnailPerson]

@DonBruce64 Disconnects third person perspective camera from vehicle orientation, when Freecam_3P is true

adwawda.mov

[DonBruce64]

@SnailPerson you're good with this being a P key config vs a keybind, right?

[SnailPerson]

I mean I could see it as a key bind

[DonBruce64]

Well, reason I'm asking is that there's provisions for it being a keybind in the code, but those don't work. I don't particularly care which it is personally. And I think both perhaps are valid. If you feel it's good enough being a config, I'm okay with that. Ask is that you remove the keybind so folks don't get confuzzled about it.

[SnailPerson]

there was a keybind? it never showed up in the normal menus though... which one was it and how could I "reenable" it?

[DonBruce64]

It was the joystick keybind menu. I apparently remove it from the keyboard keybind at one time but didn't delete the joystick one. Adding a keybind is simple. Just add an entry in the ControlSystem list at the bottom and MTS auto-populates the appropriate GUIs. Then you can check the entry as all others are.

[DonBruce64]

Strangely enough, I don't see in the commits where I did this deltion, but I know specifically I did delete the code for it at one point in time as this was a feature. I rememeber binding it to scroll lock specifically.

[SnailPerson]

hey @DonBruce64, you want to know something funny... the whole entity disappearing thing, the issue stems from exactly one line

funny

[DonBruce64]

@SnailPerson WHAT!? Where the hell did I screw that up?

[SnailPerson]

@DonBruce64 apparently tile entities are failing at the exact same tick and then disappear.
On failure, MTS currently deletes the block (level.removeBlock(...)) in BuilderTileEntity.java

the thrown error is exactly from missing pack item (null item -> generateDefaultDefinition() throw) in
AEntityD_Definable.java and AEntityD_Definable.java.

affected Forge builders were not actually preserving lastLoadedNBT when saved before
first tick (tag = lastLoadedNBT in save path), causing NBT loss

[DonBruce64]

@SnailPerson No wonder that causes issues. I'm merging the tag to itself. That's a stuipd operation. Do you have a fix or should I look into it? This is something I should be able to suss out.

EIDT: I see the PR and replied there.