Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add domchekr.com.domaincheck.json template #556

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

emmanuelgautier
Copy link
Contributor

Add a template verification for domchekr.com. This template will be used with several DNS Providers including Cloudflare for domains verification.

Copy link

Linter OK:

Linter result for domchekr.com.domaincheck.json

@pawel-kow
Copy link
Member

@emmanuelgautier is this template going to be applied more than once? If yes think of multiInstance setting.
If not and it would be required to remove the previous one before adding a new one take a look whether txtConflictMatchingMode=Prefix wouldn't be of a value to you.

@emmanuelgautier
Copy link
Contributor Author

@pawel-kow You are right, the template may be applied more than once for the same host. multiInstance is now set to true. Thanks for your review.

Copy link
Member

@pawel-kow pawel-kow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pawel-kow pawel-kow added this pull request to the merge queue Sep 20, 2024
Merged via the queue into Domain-Connect:master with commit ebc9e90 Sep 20, 2024
2 checks passed
@emmanuelgautier emmanuelgautier deleted the add-domchekr-domaincheck branch September 20, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants