Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hauberk.app template #553

Merged
merged 11 commits into from
Aug 29, 2024
Merged

Conversation

dane-stevens
Copy link
Contributor

A domain verification template for Hauberk.app

Copy link

github-actions bot commented Aug 28, 2024

Linter OK:

Linter result for hauberk.app.domain-verification.json

hauberk.app.domain-verification.json Outdated Show resolved Hide resolved
hauberk.app.domain-verification.json Outdated Show resolved Hide resolved
hauberk.app.domain-verification.json Outdated Show resolved Hide resolved
hauberk.app.domain-verification.json Outdated Show resolved Hide resolved
hauberk.app.domain-verification.json Outdated Show resolved Hide resolved
hauberk.app.domain-verification.json Outdated Show resolved Hide resolved
hauberk.app.domain-verification.json Outdated Show resolved Hide resolved
hauberk.app.domain-verification.json Outdated Show resolved Hide resolved
hauberk.app.domain-verification.json Outdated Show resolved Hide resolved
hauberk.app.domain-verification.json Outdated Show resolved Hide resolved
@dane-stevens
Copy link
Contributor Author

I read on #552 that %fqdn% is not respected by GoDaddy? Should i be using a custom variable in my template instead?

Fixes for requested changes
@dane-stevens dane-stevens requested a review from pawel-kow August 28, 2024 22:20
Copy link
Contributor Author

@dane-stevens dane-stevens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

Made dmarc and inbound non-essential
Copy link
Member

@pawel-kow pawel-kow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pawel-kow pawel-kow added this pull request to the merge queue Aug 29, 2024
Merged via the queue into Domain-Connect:master with commit 49fb938 Aug 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants