Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev #528

Closed
wants to merge 11 commits into from
Closed

Dev #528

wants to merge 11 commits into from

Conversation

arya-dos
Copy link
Contributor

@arya-dos arya-dos commented May 3, 2024

Added syncPubKeyDomain

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024 •
edited
Loading

Linter OK:

Linter result for dnsdad.com.dnsdadrecords.json

@kerolasa
Copy link
Collaborator

This pull is quite messy. First of all comments like //comment out file are not valid json. The domain connect linter does not even allow unknown json values, meaning comments using https://json-schema.org/understanding-json-schema/reference/comments will not work.

Secondly. It would be best to get the latest origin/master and re-create the arya-dos/dnsdad branch dev from scratch.

p.s. The commit you want in your dev branch is:
0001-dnsdad-add-syncPubKeyDomain.txt
Easy way to apply that file is: git am 0001-dnsdad-add-syncPubKeyDomain.txt

@arya-dos arya-dos closed this Jun 26, 2024
@arya-dos arya-dos deleted the dev branch June 26, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arya-dos @kerolasa @jatinw3nuts @pawel-kow