MailerLite templates #454
Merged
MailerLite templates #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MailerLite templates
pawel-kow
requested changes
Oct 24, 2023
mailerlite.com.domain-alignment.json
Outdated
| }, | ||
| { | ||
| "type": "SPFM", | ||
| "host": "%spf_host%", |
There was a problem hiding this comment.
Not sure why would you want SPF on a different host than MX?
| }, | ||
| { | ||
| "type": "SPFM", | ||
| "host": "%spf_host%", |
mailerlite.com.website.json
Outdated
| { | ||
| "groupId": "subdomain", | ||
| "type": "CNAME", | ||
| "host": "%subdomain_host%", |
There was a problem hiding this comment.
Do you intend to use this group always in combination with domain group, or standalone?
If standalone then a separate template would do better.
…ates Mailerlite templates updates
pawel-kow
requested changes
Oct 25, 2023
| "records": [ | ||
| { | ||
| "type": "CNAME", | ||
| "host": "%subdomain_host%", |
There was a problem hiding this comment.
For subdomain template host is typically set to @ and hostRequired set to true.
With the usage of host variable the CNAME subdomain is created on the right subdomain.
…serviceid Fix serviceid
…omain-fixes Update subdomain template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Templates for MailerLite domain authentication, domain alignment and sites.