Add NewLineAfterSuperCall Rule
#25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackertronix
commented
Aug 8, 2024
| super.visitNamedFunction(function) | ||
| function.bodyBlockExpression?.statements?.forEachIndexed { index, statement -> | ||
| if (statement.text?.startsWith("super") == true) { | ||
| if (statement.nextSibling.text.contains("\n\n")) return |
There was a problem hiding this comment.
there's likely a cleaner way to do this, but I am not super on top of detekt APIs so for now sticking with this as it works!
pedrodanielcsantos
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Thanks a lot for the update @hackertronix ! 🚀
Left a couple of small suggestions, good to go after checking them.
To make it the whole package, you can publish a new version and update Todoist afterwards. 🙏
| override fun visitNamedFunction(function: KtNamedFunction) { | ||
| super.visitNamedFunction(function) | ||
| function.bodyBlockExpression?.statements?.forEachIndexed { index, statement -> | ||
| if (statement.text?.startsWith("super") == true) { |
There was a problem hiding this comment.
Should we check here for super. (i.e. with the dot at the end), just for extra safety ?
|
|
||
| override fun visitNamedFunction(function: KtNamedFunction) { | ||
| super.visitNamedFunction(function) | ||
| function.bodyBlockExpression?.statements?.forEachIndexed { index, statement -> |
There was a problem hiding this comment.
A bit ironic but ... Can we add an empty line here, please? 😇😅
| import org.junit.jupiter.api.Test | ||
|
|
||
| @KotlinCoreEnvironmentTest | ||
| internal class NewLineAfterSuperCallTest(private val env: KotlinCoreEnvironment) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pedrodanielcsantos mentioned a formatting issue on my PR
So I've created a new rule to ensure we don't forget about it 🙂