feat: encrypt_sensitive_data/decrypt_sensitive_data#374
Open
Meshmulla wants to merge 2 commits intoDogStark:mainfrom
Open
feat: encrypt_sensitive_data/decrypt_sensitive_data#374Meshmulla wants to merge 2 commits intoDogStark:mainfrom
Meshmulla wants to merge 2 commits intoDogStark:mainfrom
Conversation
|
@Meshmulla Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
llinsss
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #308
This PR addresses a critical security issue where encrypt_sensitive_data and decrypt_sensitive_data were implemented as identity functions, providing no real confidentiality. The update replaces the mock implementation with a secure approach (or removes the misleading encryption model where appropriate), ensuring sensitive data is not trivially recoverable on-chain.
Changes Included:
Replaced identity-based encryption with a secure encryption approach or removed false encryption layer
Eliminated use of fixed nonce and direct data cloning
Introduced proper key-based or off-chain encryption strategy (as applicable)
Updated contract logic to align with the new privacy model (e.g., commit-reveal, viewing keys, or off-chain handling)
Added clear documentation on the chosen privacy model and limitations