Closed
fix: flush pending debounced localStorage saves on pagehide in standalone dev harness#1425
Conversation
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code based on review comments
fix: flush pending debounced localStorage saves on pagehide in standalone dev harness
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review comments from #pullrequestreview-4656536637 on PR #1423 (autosave dev sources in localStorage).
Changes
packages/standalone/src/test-main.tsxpendingSources: Map<string, string>to track writes scheduled but not yet persistedpagehidelistener that cancels pending timers and flushes all pending sources synchronously — mirrors the identical pattern already used indoenetml-iframe/src/test-main.tsxsaveSource()now tracks/clears entries inpendingSourcesalongsidesaveTimerspackages/doenetml-iframe/src/test-main.tsxsaveTimertype fromnumber | null→ReturnType<typeof window.setTimeout> | nullfor consistency with the standalone implementation and correctness when Node types are in scope