-
-
Notifications
You must be signed in to change notification settings - Fork 9
Advancements #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Advancements #137
Conversation
src/main/kotlin/io/github/dockyardmc/extentions/ExtendedByteBuf.kt
Outdated
Show resolved
Hide resolved
...ithub/dockyardmc/protocol/packets/play/serverbound/ServerboundSelectAdvancementsTabPacket.kt
Outdated
Show resolved
Hide resolved
Add packets and event for advancement tab selection
also THROW when icon is air.
removed TODO because codefactor shut up
* fix multiple ConcurrentModificationException :skull emoji:
How is this going :3 Are you planning on merging to 1.21.4 still? 1.21.5 will take a WHILE |
yes, im not waiting for 1.21.5, + need to fix stuff, like when deleting an advancement that has children, clients also delete all the children recursively, so need to keep track of that on server-side too also might actually make advancements mutable now that advancements will keep track of their children (you need to delete advancement and add it again to update properties, and then you probably need to send all the children again) |
oki got it |
Keep track of advancement's children and parent.
its useless but since progress map is private might be good to have some public function to get progress
yeah they actually work
instead of having one billion collections just send a packet to a client when you add advancement, or remove, or change progress * fix: add advancement viewers to the list * fix: when disposing PlayerAdvancementTracker remove itself from all visible advancements
because if you send progress of an advancement, you need to send the full progress of that advancement dont need to send every advancement tho
also get rid of advancement display, in favor of just always having it (previously it was nullable). because displayless advancements are COMPLETELY useless here
meh
no tree builder no node stuff just advancements here (means have to manually set the position)
boop:
there are toasts (the only reason you wanted advancements)
Player.showToast
extension function that takes title, icon and a framealso event for when player selects an advancement tab