Wrap header values in quotes if they contain characters that are not allowed #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not related to this issue but I don't think there needs to be this number of Elixir version checks
|
andrewtimberlake
requested changes
Mar 17, 2025
lib/mail/renderers/rfc_2822.ex
Outdated
| @@ -152,6 +153,14 @@ defmodule Mail.Renderers.RFC2822 do | |||
| defp render_subtypes([{key, value} | subtypes]) do | |||
| key = String.replace(key, "_", "-") | |||
| value = encode_header_value(value, :quoted_printable) | |||
|
|
|||
| value = | |||
| if value =~ ~r/[\s;]/ do | |||
There was a problem hiding this comment.
We should match all the tspecial characters of RFC2045
if Regex.match?(~r/[\s()<>@,;:\\<\/\[\]?=]/, value) do
@bcardarella I’ve reduced the workflow to test on explicit Elixir/Erlang pairs instead of using a matrix to test all combinations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
This PR adds quotes around header parameters if necessary. This resolves an issue where attachments with spaces in their file names would not be displayed correctly, due to the client thinking not parsing the rest of the name after the space