Open
Conversation
…ing Supports and Technical Facilitators as reviewer.
* Slide contents * Rename markdown_slides to lessons, as called for in generate_slides.sh * Automatically install marp-cli locally if node is available, but marp is not * Use npx in generate_slides.sh for compatibility with marp-cli's recommended installation location * Remove reference dsi_certificates_theme.css in unix_slides.md because it wasn't being used in recent generated versions of the slides * Adapt font CSS to improve compatibility on Windows systems
…nstead of exact match
…s that run upon PR for autograding
…it normally isn't a problem due to security restrictions on pull_target, but coding in the condition just in case.
Co-authored-by: Copilot <[email protected]>
…hub pages testing branch on other repos
…ome from a member of the UofT-DSI organization
96859a9 to
3fd9fd8
Compare
There was a problem hiding this comment.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ✅ | |
| Part 1 - Q3 | ✅ | |
| Part 1 - Q4 | ✅ | |
| Part 1 - Q5 | ❌ | Missing files in data/processed/server_logs |
| Part 1 - Q6 | ❌ | Missing files in data/processed/user_logs; Missing files in data/processed/event_logs |
| Part 1 - Q7 | ❌ | One or more files with ipaddr in data/raw not removed. |
| Part 1 - Q8 | ❌ | data/inventory.txt does not exist |
| Part 2 | ❌ | coworker-changes branch not found in commit history |
Please address the issues listed above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
@mentions of the person or team responsible for reviewing proposed changes (At least 2 people)
Checklist