Skip to content

Dis 26 landing page header navbar-leo#20

Merged
Qiming-Liu merged 11 commits intomainfrom
DIS-26-Landing-Page-Header-Navbar
Apr 28, 2025
Merged

Dis 26 landing page header navbar-leo#20
Qiming-Liu merged 11 commits intomainfrom
DIS-26-Landing-Page-Header-Navbar

Conversation

@foliage21
Copy link
Copy Markdown
Contributor

@foliage21 foliage21 commented Apr 20, 2025

Design reference: Header Navbar
Desktop:
image
Mobile:

The navbar has been implemented according to the Zeplin design.

@foliage21 foliage21 changed the title Dis 27 landing page header navbar-leo Dis 26 landing page header navbar-leo Apr 20, 2025
@Qiming-Liu Qiming-Liu requested a review from Copilot April 23, 2025 05:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request implements the header navbar on the landing page according to the Zeplin design, ensuring both desktop and mobile views are addressed. Key changes include the addition of reusable navigation item components (NavItem, DesktopNavItems, and MobileDrawer), integration of authentication buttons, and updates to the global layout to include the Roboto font.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/components/features/landing/navbar/NavItem.tsx New NavItem component for navigation links with configurable widths.
src/components/features/landing/navbar/MobileDrawer.tsx Mobile drawer implementation to render nav items and auth buttons.
src/components/features/landing/navbar/DesktopNavItems.tsx Desktop navigation items layout using a flex Stack.
src/components/features/landing/navbar/AuthButton.tsx AuthButton component with distinct styles for login and signup.
src/components/features/landing/Navbar.tsx Navbar component bringing together mobile and desktop views.
src/app/page.tsx Updated landing page to render the Navbar component.
src/app/layout.tsx Updated global layout to include the Roboto font.
Comments suppressed due to low confidence (2)

src/components/features/landing/navbar/NavItem.tsx:9

  • [nitpick] Consider renaming 'width' to a more descriptive name such as 'containerWidth' to clarify that it controls the overall component width.
  width: number;

src/components/features/landing/navbar/NavItem.tsx:10

  • [nitpick] Consider renaming 'textWidth' to a more descriptive name like 'labelWidth' to clearly indicate its purpose for the text element's width.
  textWidth: number;

@foliage21
Copy link
Copy Markdown
Contributor Author

foliage21 commented Apr 28, 2025

The file conflicts have been resolved. Thank you!

@Qiming-Liu Qiming-Liu merged commit 7e71daf into main Apr 28, 2025
1 check passed
@Qiming-Liu Qiming-Liu deleted the DIS-26-Landing-Page-Header-Navbar branch April 28, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants