Dis 26 landing page header navbar-leo#20
Merged
Qiming-Liu merged 11 commits intomainfrom Apr 28, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request implements the header navbar on the landing page according to the Zeplin design, ensuring both desktop and mobile views are addressed. Key changes include the addition of reusable navigation item components (NavItem, DesktopNavItems, and MobileDrawer), integration of authentication buttons, and updates to the global layout to include the Roboto font.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/features/landing/navbar/NavItem.tsx | New NavItem component for navigation links with configurable widths. |
| src/components/features/landing/navbar/MobileDrawer.tsx | Mobile drawer implementation to render nav items and auth buttons. |
| src/components/features/landing/navbar/DesktopNavItems.tsx | Desktop navigation items layout using a flex Stack. |
| src/components/features/landing/navbar/AuthButton.tsx | AuthButton component with distinct styles for login and signup. |
| src/components/features/landing/Navbar.tsx | Navbar component bringing together mobile and desktop views. |
| src/app/page.tsx | Updated landing page to render the Navbar component. |
| src/app/layout.tsx | Updated global layout to include the Roboto font. |
Comments suppressed due to low confidence (2)
src/components/features/landing/navbar/NavItem.tsx:9
- [nitpick] Consider renaming 'width' to a more descriptive name such as 'containerWidth' to clarify that it controls the overall component width.
width: number;
src/components/features/landing/navbar/NavItem.tsx:10
- [nitpick] Consider renaming 'textWidth' to a more descriptive name like 'labelWidth' to clearly indicate its purpose for the text element's width.
textWidth: number;
Qiming-Liu
approved these changes
Apr 23, 2025
Qiming-Liu
approved these changes
Apr 27, 2025
Contributor
Author
|
The file conflicts have been resolved. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design reference: Header Navbar

Desktop:
Mobile:
The navbar has been implemented according to the Zeplin design.