Skip to content

chore(soroban): feature address-validation #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1nonlypiece merged 2 commits into from
Apr 1, 2026
Merged

chore(soroban): feature address-validation #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4812a1
chore(soroban): feature address-validation
licette32 Mar 30, 2026
5106acc
Merge branch 'main' into feature/address-validation
1nonlypiece Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,6 +951,11 @@ During `create_vault`, the contract enforces:
- `end_timestamp` must be strictly greater than `start_timestamp`
- `end_timestamp - start_timestamp` must not exceed `MAX_VAULT_DURATION`
- `success_destination` must differ from `failure_destination` (returns `Error::SameDestination`, code `#10`); equal destinations make the success/failure outcome financially indistinguishable, removing the accountability incentive of the vault
<<<<<<< feature/address-validation
- `creator` must differ from `success_destination` and `failure_destination` (returns `Error::InvalidAddress`, code `#11`); a creator that is also a destination could trivially recover funds regardless of milestone outcome
- `verifier` (when `Some`) must differ from `creator` (returns `Error::InvalidAddress`, code `#11`); a verifier equal to the creator provides no independent validation
=======
>>>>>>> main

All validations occur before event emission or state mutation, ensuring invalid vaults cannot be created.

Expand Down
Loading