Skip to content

Fix displayed ip address #3948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

ealmloff
Copy link
Member

@ealmloff ealmloff commented Apr 2, 2025

Fixes two small issues with how the address is displayed:

  1. It can look like it is empty if just the address is trimmed. This PR hides either the entire section or shows the entire section
  2. It can be confusing if you pass in --addr 0.0.0.0 manually and see the CLI pretend it is serving at just localhost

Fixes #3847
Fixes #3836

@ealmloff ealmloff added bug Something isn't working cli Related to the dioxus-cli program labels Apr 2, 2025
@ealmloff ealmloff requested a review from a team as a code owner April 2, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli Related to the dioxus-cli program
Projects
None yet
1 participant