Skip to content

Fix escaped text in ssr stylesheets and scripts #3933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025

Conversation

ealmloff
Copy link
Member

In #3928, I noticed one of the fullstack playwright tests was pointing to the web port. The test for fullstack head elements was passing, but after switching it to the right port, it fails for two reasons:

  1. The meta head element was not getting deduplicated
  2. We try to escape text inside of script and style tags which breaks the tags

This PR fixes both issues and adds more tests

@ealmloff ealmloff added bug Something isn't working ssr server-side-rendering (prerendering) fullstack related to the fullstack crate labels Mar 31, 2025
@ealmloff ealmloff requested a review from a team as a code owner March 31, 2025 14:25
@jkelleyrtp jkelleyrtp merged commit 4f74ef8 into main Apr 8, 2025
17 checks passed
@jkelleyrtp jkelleyrtp deleted the fix-escape-stylesheet-ssr branch April 8, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fullstack related to the fullstack crate ssr server-side-rendering (prerendering)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants