partial implementation of production queue element priorities #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morlic-fo
pushed a commit
that referenced
this pull request
Jan 14, 2017
Make AddressSanitizer happy.
==5832==ERROR: AddressSanitizer: global-buffer-overflow on address 0x7f602f2e2925 at pc 0x7f602e81ce91 bp 0x7ffcdd76f600 sp 0x7ffcdd76f5f0
READ of size 1 at 0x7f602f2e2925 thread T0
#0 0x7f602e81ce90 in std::char_traits<char>::length(char const*) /usr/lib/gcc/x86_64-pc-linux-gnu/4.9.4/include/g++-v4/bits/char_traits.h:263
#1 0x7f602e81ce90 in std::string::append(char const*) /usr/lib/gcc/x86_64-pc-linux-gnu/4.9.4/include/g++-v4/bits/basic_string.h:1025
#2 0x7f602e81ce90 in std::string::operator+=(char const*) /usr/lib/gcc/x86_64-pc-linux-gnu/4.9.4/include/g++-v4/bits/basic_string.h:958
#3 0x7f602e81ce90 in ProductionQueue::ProductionItem::Dump() const /mnt/another/srcs/GIT/freeorion/Empire/Empire.cpp:774
0x7f602f2e2925 is located 0 bytes to the right of global variable '*.LC128' from '/mnt/another/srcs/GIT/freeorion/Empire/Empire.cpp' (0x7f602f2e2920) of size 5
'*.LC128' is ascii string 'id: '
0x7f602f2e2925 is located 59 bytes to the left of global variable '*.LC129' from '/mnt/another/srcs/GIT/freeorion/Empire/Empire.cpp' (0x7f602f2e2960) of size 27
'*.LC129' is ascii string 'ProductionQueue::Element ('
SUMMARY: AddressSanitizer: global-buffer-overflow /usr/lib/gcc/x86_64-pc-linux-gnu/4.9.4/include/g++-v4/bits/char_traits.h:263 std::char_traits<char>::length(char const*)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this PR just to facilitate discussion of this as a possible approach; it is still quite incomplete and I'm not even sure I want to head in this direction anymore. I've had some more thought about the larger priority framework, which I'll post in the related FO forum thread.