Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mediapicker3 support #3

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Conversation

nickh364
Copy link

Added mediapicker3 support for Umbraco 8.14 >

Added mediapicker3 support for Umbraco 8.14 >
@dinc5150 dinc5150 changed the base branch from master to V1/1.2 June 24, 2021 09:46
@dinc5150
Copy link
Contributor

Thanks for the PR @nickh364 . I've gone through and its mostly tested OK, I'll just need to change the way you assign $scope.model.value.shareImage due to an issue with the PropertyValueConverter and some backwards compatibility.

You've done the hard work though, so thanks!

@dinc5150 dinc5150 merged commit 2e91dca into DigitalMomentum:V1/1.2 Jun 24, 2021
dinc5150 added a commit that referenced this pull request Jun 24, 2021
@dinc5150
Copy link
Contributor

P.S. If you'd like to try out the latest pre-release version, you can install it from the MyGet Feed - https://www.myget.org/feed/digital-momentum/package/nuget/MetaMomentum

@dinc5150 dinc5150 added this to the Release 1.2 milestone Jul 7, 2021
@dinc5150
Copy link
Contributor

dinc5150 commented Jul 7, 2021

@nickh364 , I have published your pull request in V1.2 to nuget and our.umbraco.com.

Thanks for your contribution!

@nickh364
Copy link
Author

nickh364 commented Jul 7, 2021

@dinc5150 Thanks for letting me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants