Skip to content

Conversation

@ecapuano
Copy link
Collaborator

@ecapuano ecapuano commented Jul 15, 2025

Release v1.4.1

Summary

This release fixes a critical bug where the stateful processing setting in backtests was inverted, causing DetectionForge to produce different results than LimaCharlie's native replay feature.

Changes

  • Fixed: Inverted stateful processing logic - Fixed boolean inversion that caused backtests to run with opposite stateful setting than selected

Technical Details

The isStateful parameter was being inverted (\!backtestConfig.isStateful) when passed to the API in three locations:

  1. Parallel backtest execution
  2. Sequential backtest execution
  3. Load more results functionality

This caused:

  • Checkbox unchecked (false) → API received true (stateful enabled)
  • Checkbox checked (true) → API received false (stateful disabled)

Testing

To verify the fix:

  1. Run a backtest with "Enable stateful processing" unchecked
  2. Compare results with LimaCharlie's native replay
  3. Results should now match when using the same time period and rule

Release Checklist

  • Code changes implemented and tested
  • Changelog updated in src/utils/version.ts
  • Version bumped to 1.4.1
  • CI/CD validation passed
  • Ready for merge

cc @ecapuano

@ecapuano ecapuano merged commit 0f4de63 into main Jul 15, 2025
1 check passed
@ecapuano ecapuano deleted the release/v1.4.1 branch July 15, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants