Fix import statement with "subpackages" in converted ESModule #69
Conversation
ztl8702
changed the title
| // To: import {bar as foo} from "@improbable-eng/grpc-web"; | ||
| return contents.replace(/var ([\w\d_]+) = require\((['"][\w\d@/_-]+['"])\)\.([\w\d_]+);/g, | ||
| (_, varName, moduleIdentifier, propertyName) => | ||
| propertyName == varName ? `import { ${varName} } from ${moduleIdentifier}` |
There was a problem hiding this comment.
Is this check needed? It makes the code look cleaner, but since this code is generated anyways I don't think it really matters. I think you could just do: 'import {$3 as $1} from $2;
test/BUILD.bazel
Outdated
|
|
||
| ts_library( | ||
| name = "rollup_test_spec", | ||
| testonly = 1, |
There was a problem hiding this comment.
Optional: You can use True instead of 1
test/BUILD.bazel
Outdated
| ], | ||
| ) | ||
|
|
||
| ts_library( |
There was a problem hiding this comment.
I was a little confused why you duplicated the rollup test until I saw your comment: "because it runs on Node.js instead of the browser".
Can you change the names of both tests to indicate what's being tested? E.g. rollup_in_node_test and rollup_in_browser_test.
test/BUILD.bazel
Outdated
| ], | ||
| browsers = [ | ||
| "@io_bazel_rules_webtesting//browsers:chromium-local", | ||
| ], |
There was a problem hiding this comment.
You'll need to add the files:
# Files are served under /base/<WORKSPACE_NAME>/<path>
static_files = [
"@npm//:node_modules/@improbable-eng/grpc-web/dist/grpc-web-client.umd.js",
"@npm//:node_modules/browser-headers/dist/browser-headers.umd.js",
":test_es6_bundling",
],
test/BUILD.bazel
Outdated
| @@ -106,13 +106,13 @@ rollup_bundle( | |||
| entry_points = { | |||
| ":test_bundling.ts": "index", | |||
| }, | |||
| format = "cjs", | |||
There was a problem hiding this comment.
Make this umd so it can be loaded in both node and the browser.
You'll also need to add to the rollup config:
output: {
name: "test_es6_bundling",
},
| @@ -0,0 +1,49 @@ | |||
| declare function require(module: string): any; | |||
There was a problem hiding this comment.
You can do:
import * as bundle from 'test_es6_bundling';
You'll also need a declaration file to get this to compile. I couldn't figure out how to export one, so I just added:
// test/test_es6_bundling.d.ts
declare module "test_es6_bundling" {
var a: any;
export = a;
}
And added it to the srcs of the test.
test/BUILD.bazel
Outdated
| tags = ["native"], | ||
| deps = [ | ||
| ":rollup_test_spec", | ||
| ":test_es6_bundling", |
There was a problem hiding this comment.
I think this can be removed if it's in the static_files
- Incorporates changes from #69
- Incorporates changes from #69
Fixes #64
Now the tricky thing is how to test it 🤔 : the test case I added in #67 would fail (error because it runs on Node.js instead of the browser. I am trying to figure out how to run
rollup_test.spec.jsin Karma.