Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1416. Skip Git-detected binary files in both Band definition and caller searches while continuing to search tracked and untracked text.
Evidence
-Ibefore this change and include it afterwards.npm test,node scripts/check-rule-copies.js, andnode scripts/check-versions.jspassed on Windows with pandas installed.claude plugin test .on Linux: 31 passed, including the new regression; 2 terminal-layout tests failed both before and after this change with the same expected/actual values.Merge Danger
Two-way; limited to Band's repository searches. Git's binary detection will also exclude text files that Git treats as binary. The macOS memory usage reported in the issue was not measured locally.
AI disclosure: OpenAI Codex generated the patch, test, and PR description; the commands and results above were checked in the local test environment.