Skip to content

fix(band): send task names to the webhook only when asked - #1407

Open
duathron wants to merge 1 commit into
DietrichGebert:mainfrom
duathron:fix/webhook-names-opt-in
Open

duathron wants to merge 1 commit into
DietrichGebert:mainfrom
duathron:fix/webhook-names-opt-in

Conversation

@duathron

Copy link
Copy Markdown

The band's optional webhook sends each task's row after every turn. With sendNames defaulting to true, setting a webhook URL also sends the task's name, which is the sidebar title or the first line of the first prompt. That line can contain a customer name, an internal project name or a pasted secret, and it goes to whoever owns the URL.

This PR makes names opt-in:

  • .claude-plugin/plugin.json: sendNames now defaults to false, and the description says so.
  • hooks/band/register.tsx: names are sent only when sendNames === true, so an unset option no longer sends them.
  • tests/band-webhook-names.test.js: pins the manifest default and the check in register.tsx. It runs in npm test, since tests/band.test.tsx is not part of CI.

Nothing changes for local use. The ledger and the board still show names. Anyone who wants names on a team board turns sendNames on.

Tests: node --test tests/*.test.js gives 144 of 145 passing. The one failure is csv: correct pandas one-liner passes, which also fails on main in my environment (no pandas). npm test --prefix pi-extension passes 30 of 30. claude plugin test . gives 30 passing and 2 failing, and the two failing layout tests fail on main too.

🤖 Generated with Claude Code

https://claude.ai/code/session_01J9HLRpQYgqTqGkrBigkfaS

The first prompt line can carry a customer name or a secret, and it left
the machine by default. sendNames now defaults to false, and an unset
option means no names. Users who want names on a team board turn it on.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant