Repository navigation
fix(band): keep a task name with a carriage return in one ledger row - #1399
Open
daviorlando wants to merge 1 commit into
Open
daviorlando wants to merge 1 commit into
daviorlando wants to merge 1 commit into
Conversation
A prompt typed with CRLF line endings kept a trailing \r in the task name. csvField did not quote \r but parseCsv ends a row on it, so the row split in two: the board showed a broken extra task and resume() lost the token and time columns. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
\r?\n.csvFieldquotes a field that contains\r, so no other source of names can split a row either.Added a test to
tests/band.test.tsxfor a name ending in\r. I can't run that file outside Claude Code (it importsclaude-code/testing), so I ran the same check against the realmetrics.ts/board.tsin Node 24: two rows before the change, one after.npm test,check-rule-copiesandcheck-versionspass. The only failure is the pandas CSV case, which fails because pandas isn't installed locally, same as onmain.Fixes #1398
🤖 Generated with Claude Code